[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 10:11:16 PST 2022


craig.topper added a comment.

Need a rv64zfa-invalid.s test to make sure we don't parse these instructions if the Zfa feature isn't enabled.



================
Comment at: llvm/test/MC/RISCV/rv64zfa.s:1
+# RUN: llvm-mc %s -triple=riscv64 -mattr=+experimental-zfa,+d,+zfh -riscv-no-aliases -show-encoding \
+# RUN:     | FileCheck -check-prefixes=CHECK-ASM,CHECK-ASM-AND-OBJ %s
----------------
Aren't our assembler tests usually named something like rv64zfa-valid.s?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460



More information about the llvm-commits mailing list