[PATCH] D140337: Propagate branchweight through phi values when ExpectedValue is unlikely in LowerExpectIntrinsic

[Zhi Zhuang via Phabricator via llvm-commits]

LukeZhuang added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:137
+    double TrueProb = Confidence->getValueAPF().convertToDouble();
+    ExpectedValueIsLikely = (TrueProb > 0.5);
+  }
----------------
davidxl wrote:
> This should probably be made more biased.
Hi David, thanks for the comment! May I ask is "more biased" meant by a higher threshold of considering a branch likely/unlikely? Or could you give an example of which it ought to behave differently than this code(and why)? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140337/new/

https://reviews.llvm.org/D140337