[PATCH] D140479: [docs] Add tips on writing test constraints

[Louis Dionne via Phabricator via llvm-commits]

ldionne added a comment.

Thanks for writing this! This LGTM but I would suggest dumbing down your target example even more.



================
Comment at: llvm/docs/TestingGuide.rst:571-573
+``target={{.*(free|net)bsd.*}}`` and that would work. However, it would
+prevent a ``grep freebsd`` from finding this test. Better to use 
+``target={{.*(freebsd|netbsd).*}}`` in this case.
----------------
I might even suggest doing `target={{.+}}-freebsd-{{.+}} || target={{.+}}-netbsd-{{.+}}`. Characters are cheap and IMO this is clearer than trying to cram more logic into something smaller.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140479/new/

https://reviews.llvm.org/D140479