[PATCH] D137982: Reland "[pgo] Avoid introducing relocations by using private alias"

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

This caused lld on mac to assert when building instrumented clang (or
instrumented code in general):

  $ export SDKROOT=$(xcrun --show-sdk-path)
  $ cat /tmp/a.cc
  #include <cerrno>
  #include <iostream>
  #include <string>
  #include <system_error>
  
  std::string getMessageFor(int err) {
      return std::make_error_code(static_cast<std::errc>(err)).message();
  }
  
  int main() {
      std::cout << getMessageFor(ENOENT) << ';' << getMessageFor(EISDIR);
      std::cout << ';' << getMessageFor(EINVAL) << ';' << getMessageFor(EACCES);
  }
  $ build/bin/clang++ /tmp/a.cc -fprofile-generate=/tmp/foo -fuse-ld=lld -O3
  Assertion failed: (!isWeakDefCanBeHidden && "weak_def_can_be_hidden on already-hidden symbol?"), function createDefined, file InputFiles.cpp, line 699.

I'll revert it for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137982/new/

https://reviews.llvm.org/D137982