[PATCH] D140411: SCCP: Don't assert on constantexpr casts of function uses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 06:15:59 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SCCP.cpp:350
+      // FIXME: Could this be a ConstantExpr cast user with a use in a call site
+      // that needs to be handled?
       for (Use &Arg : CB->args())
----------------
nikic wrote:
> If I understood things correctly, I don't think so: We only look through casts for assume-like intrinsics, and for those it's not a call use, so there's no attributes to drop.
I think if hasAddressTaken looked at nocapture attributes, we could reach here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140411/new/

https://reviews.llvm.org/D140411



More information about the llvm-commits mailing list