[PATCH] D140347: TargetLowering: Teach DemandedBits about VSCALE

Wed Dec 21 05:35:47 PST 2022

benmxwl-arm added a comment.

In D140347#4008253 <https://reviews.llvm.org/D140347#4008253>, @compnerd wrote:

> In D140347#4006583 <https://reviews.llvm.org/D140347#4006583>, @craig.topper wrote:
>
>> BTW, why is this in SimplifyDemandedBits instead of computeKnownBits? It doesn't use the DemandedBits.
>
> I couldn't answer that tbh, perhaps @benmxwl-arm can answer that.  I am only trying to help restore the patch that I reverted due to it regressing RVV.

Sorry, that's my bad. It's perfectly fine to move this over to `computeKnownBits()`. 
Just replace `return false`s with `break`s and `TLO.DAG.getMachineFunction()` with `getMachineFunction()` and it works fine moving this case over there.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140347/new/

https://reviews.llvm.org/D140347