[PATCH] D140473: [AVR][MC] Fix illegal operand forms.

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 04:26:01 PST 2022


benshi001 created this revision.
benshi001 added reviewers: aykevl, dylanmckay.
Herald added subscribers: Jim, hiraditya.
Herald added a project: All.
benshi001 requested review of this revision.
Herald added subscribers: llvm-commits, jacquesguan.
Herald added a project: LLVM.

  These operands are illegal and rejected by avr-gcc.
      subi    r24, -lo8(symobl+offset)
      sbci    r25, -hi8(symobl+offset)
  
  And their correct form should be
      subi    r24, lo8(-(symobl+offset))
      sbci    r25, hi8(-(symobl+offset))


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140473

Files:
  llvm/lib/Target/AVR/AsmParser/AVRAsmParser.cpp
  llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
  llvm/test/CodeGen/AVR/elpm.ll
  llvm/test/CodeGen/AVR/lpmx.ll
  llvm/test/MC/AVR/modifiers.s
  llvm/test/MC/AVR/relocations.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140473.484528.patch
Type: text/x-patch
Size: 19336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221221/dc076147/attachment.bin>


More information about the llvm-commits mailing list