[PATCH] D140458: [RewriteStatepointsForGC] Remove the hardcoded GC strategy names

Denis Antrushin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 03:25:55 PST 2022


dantrushin added a comment.

In D140458#4010049 <https://reviews.llvm.org/D140458#4010049>, @znix wrote:

> I'm not sure why the tests are failing? It looks like a linkage issue:
>
> `LLVM ERROR: unsupported GC: statepoint-example (did you remember to link and initialize the library?)`
>
> I'm not sure why this would occur in the tests, but not locally. I built with `BUILD_SHARED_LIBS` which I'm guessing has something to do with it, but `llvm/lib/IR/BuiltinGCs.cpp` (where the statepoint-example GC registration is located) is in LLVMCore so I'd expect it to always be initialised?

This exact issue prevented me from landing similar patch in the past. And I did not figure out what was going on there.
static initializers are definitely running, but at the time RS4GC runs relevant array is zeroed (is BSS initialization happens _after_ C++ static initializers? or we have multiple copies?)
Unfortunately I had not enough time to find out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140458/new/

https://reviews.llvm.org/D140458



More information about the llvm-commits mailing list