[PATCH] D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading

Ben Mudd via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 02:33:17 PST 2022


BenJMudd added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SSAUpdater.cpp:221
+  else
+    NewVal = UndefValue::get(I->getType());
+  DbgValue->replaceVariableLocationOp(I, NewVal);
----------------
nlopes wrote:
> Please use PoisonValue as placeholder whenever possible. We are trying to get rid of undef in LLVM.
> Thank you!
This patch doesnt introduce any newly created undef Values, just moving where they're created, so I believe it should stay undef for now, until this and the relevant tests are migrated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140404/new/

https://reviews.llvm.org/D140404



More information about the llvm-commits mailing list