[PATCH] D140405: [CVP] Simplify SRem when constantrange abs(lhs) < abs(rhs)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 21 02:13:36 PST 2022


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/CorrelatedValuePropagation/srem.ll:541
   %rem = srem i8 %x, %y
   %cmp = icmp ne i8 %rem, %x
   ret void
----------------
nit: I think it would be cleaner to `return i32 %rem` from these tests, rather than using in an icmp that doesn't really seem relevant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140405/new/

https://reviews.llvm.org/D140405



More information about the llvm-commits mailing list