[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 23:59:57 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:132
+                       [FeatureStdExtF]>;
+def HasStdExtZfa : Predicate<"Subtarget->hasStdExtZfa()">,
+                             AssemblerPredicate<(all_of FeatureStdExtZfa),
----------------
This isn't used anywhere.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfa.td:1
+//===-- RISCVInstrInfoZfh.td - RISC-V 'Zfa' instructions ---*- tablegen -*-===//
+//
----------------
File name says Zfh


================
Comment at: llvm/test/MC/RISCV/rv64zfa.s:82
+fleq.h a1, ft1, ft2
\ No newline at end of file

----------------
Add new line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460



More information about the llvm-commits mailing list