[PATCH] D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 21:41:01 PST 2022


oontvoo added a comment.

In D140225#4006999 <https://reviews.llvm.org/D140225#4006999>, @int3 wrote:

> Okay, you've convinced me. But just to clarify some of what I said earlier:
>
>> You've pointed out that we shouldn't require people to turn off warnings, but this proposed change would not introduce more warnings/errors than whatever already exists
>
> Yes, but it still makes turning on `-fatal_warnings` harder. And I would like to be able to turn it on for most of our builds. (We are already looking at downgrading certain warnings internally to achieve this, but I would like to minimize the number of local patches.)

Well, this patch can't make it any harder because it downgrades errors to warnings. In other words, such builds would be already broken -  this would "unbreak" them, in exchange for some additional warnings


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140225/new/

https://reviews.llvm.org/D140225



More information about the llvm-commits mailing list