[PATCH] D133340: [PowerPC][GISel]select floating point constant from TOC

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:72
 
+G_CONSTANT_POOL_INDEX
+^^^^^^^^^^^^^^^^^^^^^
----------------
shchenz wrote:
> arsenm wrote:
> > Just G_CONSTANT_POOL?
> I use `G_CONSTANT_POOL_INDEX` instead of `G_CONSTANT_POOL` is because of the name used in `lib/CodeGen/GlobalISel/MachineIRBuilder.cpp`. According to the name convention there, `MachineIRBuilder::buildConstantPool()` is a little confused to me. If you insist, I can change this to `G_CONSTANT_POOL`.
I don't follow what you mean about the convention. The index is just what the source happens to be. This returns a constant pool. It's also called ConstantPool in the dag, so this should be G_CONSTANT_POOL


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133340/new/

https://reviews.llvm.org/D133340