[PATCH] D140449: [BOLT][NFC] Make DataflowAnalysis::AnnotationIndex std::optional

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 18:31:20 PST 2022


Amir created this revision.
Amir added a reviewer: bolt.
Herald added subscribers: treapster, ayermolo, arphaman.
Herald added a reviewer: rafauler.
Herald added a reviewer: maksfb.
Herald added a project: All.
Amir requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140449

Files:
  bolt/include/bolt/Passes/DataflowAnalysis.h
  bolt/lib/Passes/ShrinkWrapping.cpp
  bolt/lib/Passes/ValidateInternalCalls.cpp


Index: bolt/lib/Passes/ValidateInternalCalls.cpp
===================================================================
--- bolt/lib/Passes/ValidateInternalCalls.cpp
+++ bolt/lib/Passes/ValidateInternalCalls.cpp
@@ -43,7 +43,7 @@
   friend class DataflowAnalysis<StackPointerTrackingForInternalCalls,
                                 std::pair<int, int>>;
 
-  Optional<unsigned> AnnotationIndex;
+  std::optional<unsigned> AnnotationIndex;
 
 protected:
   // We change the starting state to only consider the first block as an
Index: bolt/lib/Passes/ShrinkWrapping.cpp
===================================================================
--- bolt/lib/Passes/ShrinkWrapping.cpp
+++ bolt/lib/Passes/ShrinkWrapping.cpp
@@ -1465,7 +1465,7 @@
   decltype(ShrinkWrapping::Todo) &TodoMap;
   DataflowInfoManager &Info;
 
-  Optional<unsigned> AnnotationIndex;
+  std::optional<unsigned> AnnotationIndex;
 
 protected:
   void compNextAux(const MCInst &Point,
Index: bolt/include/bolt/Passes/DataflowAnalysis.h
===================================================================
--- bolt/include/bolt/Passes/DataflowAnalysis.h
+++ bolt/include/bolt/Passes/DataflowAnalysis.h
@@ -152,7 +152,7 @@
     return *static_cast<const Derived *>(this);
   }
 
-  mutable Optional<unsigned> AnnotationIndex;
+  mutable std::optional<unsigned> AnnotationIndex;
 
 protected:
   const BinaryContext &BC;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140449.484442.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221221/38ba2483/attachment.bin>


More information about the llvm-commits mailing list