[PATCH] D139888: [lld][ARM] support absolute thunks for Armv4T Thumb and interworking

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Looks great!



================
Comment at: lld/ELF/Thunks.cpp:1164
+      fatal("PIC relocations across state change not supported for Armv4T");
+    else if (config->picThunk && thumb_target)
+      return make<ThumbV6MPILongThunk>(s, a);
----------------



================
Comment at: lld/ELF/Thunks.cpp:1168
+      return make<ThumbV4ABSLongBXThunk>(s, a);
+    else
+      return make<ThumbV4ABSLongThunk>(s, a);
----------------
Delete `else`. Also, when the code is similarly beautiful with a positive or a negative condition, prefer a positive condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139888/new/

https://reviews.llvm.org/D139888