[PATCH] D140435: [BOLT] Respect -function-order in lite mode

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 15:56:19 PST 2022


maksfb accepted this revision.
maksfb added inline comments.
This revision is now accepted and ready to land.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:2759
 
+  std::unordered_set<std::string> ReorderFunctionsUserSet;
+  if (opts::ReorderFunctions == ReorderFunctions::RT_USER) {
----------------
Maybe use `StringSet<>`?


================
Comment at: bolt/test/X86/function-order-lite.s:29-40
+.LBB07:
+.LBB07_br: 	jmp	.Ltmp6
+
+.LFT1:
+.LFT1_br: 	jmp	.Ltmp7
+
+.Ltmp6:
----------------
What's the purpose of the jumps in the test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140435/new/

https://reviews.llvm.org/D140435



More information about the llvm-commits mailing list