[PATCH] D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1840
     with the ``alwaysinline`` attribute.
+``nooutline``
+    This attribute indicates that no outliner pass should ever outline from
----------------
arsenm wrote:
> This is documented as a first class enum attribute, but the code is using a string attribute. If it's an enum attribute, the code needs to change. If it's a string attribute, it should go below with the others and be expressed with quotes
It doesn't seem like these are grouped by being string attributes/not string attributes.

The last string attribute is `"min-legal-vector-width"`; should I move it after that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140438/new/

https://reviews.llvm.org/D140438