[PATCH] D140438: [IR/MachineOutliner] Add a "nooutline" function attr and respect it

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1840
     with the ``alwaysinline`` attribute.
+``nooutline``
+    This attribute indicates that no outliner pass should ever outline from
----------------
This is documented as a first class enum attribute, but the code is using a string attribute. If it's an enum attribute, the code needs to change. If it's a string attribute, it should go below with the others and be expressed with quotes


================
Comment at: llvm/test/Transforms/IROutliner/nooutline-attribute.ll:20
+
+define i8 @nooutline2(i8* noalias %s, i8* noalias %d, i64 %len) "nooutline" {
+  %a = load i8, i8* %s
----------------
No typed pointers in new tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140438/new/

https://reviews.llvm.org/D140438