[PATCH] D139902: IR: Add nofpclass parameter attribute
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 20 15:00:50 PST 2022
arsenm added inline comments.
================
Comment at: llvm/docs/LangRef.rst:1409
+ indicated by ``nofpclass``, the value read is a :ref:`poison value
+ <poisonvalues>`.
+
----------------
nikic wrote:
> The wording here is unusual -- we'd normally just say that the argument/return is poison. Why the focus on the using operation here?
I'm mostly worried about allowing clang to just throw nofpclass(nan) on every float parameter with -ffinite-math-only. What if someone is just using a floating point operand for nan boxing, and never actually performs a floating point operation on it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139902/new/
https://reviews.llvm.org/D139902
More information about the llvm-commits
mailing list