[PATCH] D140427: [YAML] Support serializing MutableArrayRef

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Support/YAMLTraits.h:1982
+    : IsFlowSequenceBase<Flow>, IsResizableBase<T, IsResizable<T>::value> {
+private:
+public:
----------------
delete private and public


================
Comment at: llvm/unittests/Support/YAMLIOTest.cpp:3273
+    // Initialize to int max as a sentinel value.
+    for (auto &V : Values)
+      V = std::numeric_limits<int>::max();
----------------
It seems that this file uses lower-case variable names.


================
Comment at: llvm/unittests/Support/YAMLIOTest.cpp:3336
+  }
+
+}
----------------
delete the blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140427/new/

https://reviews.llvm.org/D140427