[PATCH] D140420: [Support] Update modulemap for TargetParser

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 12:56:57 PST 2022


steven_wu added inline comments.


================
Comment at: llvm/include/llvm/module.modulemap:403
+    // Exclude this; it is a forwarding header to TargetParser.
+    exclude header "ADT/Triple.h"
   }
----------------
I am not sure if this exclude is necessary. It is ok for ADT to depend on TargetParser, correct?

We should either clean up all the include through ADT, or maybe just leave this. Same for all the TargetParser header in Support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140420/new/

https://reviews.llvm.org/D140420



More information about the llvm-commits mailing list