[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.

[Jose Manuel Monsalve Diaz via Phabricator via llvm-commits]

josemonsalve2 added a comment.

In D133949#4006520 <https://reviews.llvm.org/D133949#4006520>, @jdoerfert wrote:

>> I could not find source declarations for:
>>
>> __kmpc_get_hardware_num_blocks()       // __kmpc_get_hardware_num_threads_in_block looks similar and is returning uint
>
> We somehow dropped this one and stopped using it. It was introduced in https://reviews.llvm.org/D106390, @josemonsalve2 can you take a look to re-introduce it (separate review).

@jdoerfert If I remember correctly the name of these functions were changed to be compliant with the rest of the interface. They were still being used as part of the deviceRTL common interface. However, the calls to these functions must have been removed later on in the modifications to the runtime. I am ok if they disappear, if they are not being called. I could also add the necessary information if you think we will use these functions in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133949/new/

https://reviews.llvm.org/D133949