[llvm] 2bf17cc - ValueTracking: Teach isKnownNeverInfinity about llvm.sin/llvm.cos

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 10:17:09 PST 2022


Author: Matt Arsenault
Date: 2022-12-20T13:17:03-05:00
New Revision: 2bf17cc0482c6928ded4ee8096ded648a766f2aa

URL: https://github.com/llvm/llvm-project/commit/2bf17cc0482c6928ded4ee8096ded648a766f2aa
DIFF: https://github.com/llvm/llvm-project/commit/2bf17cc0482c6928ded4ee8096ded648a766f2aa.diff

LOG: ValueTracking: Teach isKnownNeverInfinity about llvm.sin/llvm.cos

Added: 
    

Modified: 
    llvm/lib/Analysis/ValueTracking.cpp
    llvm/test/Transforms/InstSimplify/floating-point-compare.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 037d2fb02522..c97092b6abdf 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -3803,6 +3803,10 @@ bool llvm::isKnownNeverInfinity(const Value *V, const TargetLibraryInfo *TLI,
 
     if (const auto *II = dyn_cast<IntrinsicInst>(V)) {
       switch (II->getIntrinsicID()) {
+      case Intrinsic::sin:
+      case Intrinsic::cos:
+        // Return NaN on infinite inputs.
+        return true;
       case Intrinsic::fabs:
       case Intrinsic::sqrt:
       case Intrinsic::canonicalize:

diff  --git a/llvm/test/Transforms/InstSimplify/floating-point-compare.ll b/llvm/test/Transforms/InstSimplify/floating-point-compare.ll
index b5e7505ee524..e071f142a35c 100644
--- a/llvm/test/Transforms/InstSimplify/floating-point-compare.ll
+++ b/llvm/test/Transforms/InstSimplify/floating-point-compare.ll
@@ -1843,9 +1843,7 @@ declare double @llvm.sqrt.f64(double)
 ; No source check required
 define i1 @isKnownNeverInfinity_sin(double %x) {
 ; CHECK-LABEL: @isKnownNeverInfinity_sin(
-; CHECK-NEXT:    [[E:%.*]] = call double @llvm.sin.f64(double [[X:%.*]])
-; CHECK-NEXT:    [[R:%.*]] = fcmp une double [[E]], 0x7FF0000000000000
-; CHECK-NEXT:    ret i1 [[R]]
+; CHECK-NEXT:    ret i1 true
 ;
   %e = call double @llvm.sin.f64(double %x)
   %r = fcmp une double %e, 0x7ff0000000000000
@@ -1857,9 +1855,7 @@ declare double @llvm.sin.f64(double)
 ; No source check required
 define i1 @isKnownNeverInfinity_cos(double %x) {
 ; CHECK-LABEL: @isKnownNeverInfinity_cos(
-; CHECK-NEXT:    [[E:%.*]] = call double @llvm.cos.f64(double [[X:%.*]])
-; CHECK-NEXT:    [[R:%.*]] = fcmp une double [[E]], 0x7FF0000000000000
-; CHECK-NEXT:    ret i1 [[R]]
+; CHECK-NEXT:    ret i1 true
 ;
   %e = call double @llvm.cos.f64(double %x)
   %r = fcmp une double %e, 0x7ff0000000000000


        


More information about the llvm-commits mailing list