[PATCH] D140373: [WebAssembly][LiveDebugValues] Handle target index defs
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 20 10:00:01 PST 2022
aheejin added a comment.
@jmorse I have a separate question again, if you don't mind 😅
When there's a register def, this pass doesn't insert `DBG_VALUE $noreg` right after it to terminate its impact; this just deletes its info from `OpenRanges` so that it doesn't get propagated to its `OutLocs`. I did the same for our Wasm target indices, because it looks that's the way this pass works. But do you know why this pass was designed that way? I think adding `DBG_VALUE $noreg` right after the new def would make debug info more precise within the BB.
And another thing, I didn't add anything to copy handling because Wasm doesn't have copy instructions. (This COPY instruction <https://github.com/llvm/llvm-project/blob/41dd02e8575144e576e9ad111bbdc3f856c58445/llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td#L286-L293> is a pseudo instruction and should have been lowered into other instructions at this phase.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140373/new/
https://reviews.llvm.org/D140373
More information about the llvm-commits
mailing list