[PATCH] D140388: llvm-reduce: Disable crash reports, symbolization and core dumps

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

thanks, I've always manually added LLVM_DISABLE_SYMBOLIZATION to the reproducer, this is nicer



================
Comment at: llvm/test/tools/llvm-reduce/Inputs/test-crash-vars.py:7
+
+sys.exit(disable_crash_report != "1" or disable_symbolization != "1")
----------------
a comment here that both env vars being "1" is interesting would be nice, it took a non-trivial amount of time to work out


================
Comment at: llvm/tools/llvm-reduce/llvm-reduce.cpp:111-112
+#ifdef _WIN32
+  SetEnvironmentVariableA("LLVM_DISABLE_CRASH_REPORT", "1");
+  SetEnvironmentVariableA("LLVM_DISABLE_SYMBOLIZATION", "1");
+#else
----------------
win premerge bot is failing, you need

```
#ifdef _WIN32
#include <windows.h>
#endif
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140388/new/

https://reviews.llvm.org/D140388