[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 07:49:03 PST 2022


jhuber6 added a comment.

In D133949#4006520 <https://reviews.llvm.org/D133949#4006520>, @jdoerfert wrote:

>> __kmpc_is_generic_main_thread_id()     // guessing it's returning int8_t, like e.g. kmpc_is_spmd_exec_mode, guessing arg is int32_t
>
> We reordered the runtime, @jhuber6 can you check if we still need this and the folding code?

I don't think it's still needed, we used to have some special initialization code only the main thread did and this would fold out the conditional if we knew only the main thread executed it anyway. That was deleted at some point, I can remove this code since it's only present in OpenMPOpt now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133949/new/

https://reviews.llvm.org/D133949



More information about the llvm-commits mailing list