[PATCH] D140400: [clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files

[Alex Bradbury via Phabricator via llvm-commits]

asb created this revision.
asb added reviewers: kito-cheng, reames, craig.topper, luismarques.
Herald added subscribers: wingo, sunshaoce, pmatos, VincentWu, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
asb requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.

After D134050 <https://reviews.llvm.org/D134050>, it makes sense to combine the RV64 ABI tests into a single file in order to make it more maintainable (i.e. not having to split tests based on the combinations of ABIs they're expected to impact). This patch deletes duplicated tests but doesn't do much further reorganisation beyond that.

I imagine the logical ordering of tests in the file and comments could be further improved in the future. My personal feeling is that it's probably not worth investing the time to try to get this "perfect", and to instead settle for this incremental step forward. But if there's reviewer interest in attempting to further iterate, I'm happy to do so.


https://reviews.llvm.org/D140400

Files:
  clang/test/CodeGen/RISCV/riscv32-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-ilp32d-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32d-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32f-abi.c
  clang/test/CodeGen/RISCV/riscv32-ilp32f-ilp32d-abi.c
  clang/test/CodeGen/RISCV/riscv32-int128-abi.c
  clang/test/CodeGen/RISCV/riscv64-abi.c
  clang/test/CodeGen/RISCV/riscv64-lp64-abi.c
  clang/test/CodeGen/RISCV/riscv64-lp64-lp64f-abi.c
  clang/test/CodeGen/RISCV/riscv64-lp64-lp64f-lp64d-abi.c
  clang/test/CodeGen/RISCV/riscv64-lp64d-abi.c
  clang/test/CodeGen/RISCV/riscv64-lp64f-lp64d-abi.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140400.484265.patch
Type: text/x-patch
Size: 222433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221220/1ce1e5f0/attachment-0001.bin>