[llvm] def915c - [DebugInfo] Variables with only empty values emitting when one is variadic

[Stephen Tozer via llvm-commits]

Author: Stephen Tozer
Date: 2022-12-20T11:51:38Z
New Revision: def915c39cc4e18b304c7a8c4761cc4531c3bc4b

URL: https://github.com/llvm/llvm-project/commit/def915c39cc4e18b304c7a8c4761cc4531c3bc4b
DIFF: https://github.com/llvm/llvm-project/commit/def915c39cc4e18b304c7a8c4761cc4531c3bc4b.diff

LOG: [DebugInfo] Variables with only empty values emitting when one is variadic

This patch fixes a simple bug in DbgValueHistoryMap::hasNonEmptyLocation
that caused it to treat empty DBG_VALUE_LIST instructions as non-empty
when determining whether to emit a variable or not.

Differential Revision: https://reviews.llvm.org/D133925

Added: 
    

Modified: 
    llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
    llvm/test/DebugInfo/X86/dbg_value_list_emission.mir

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp b/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
index 42715efbee09d..2c90b9c150098 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
@@ -264,7 +264,7 @@ bool DbgValueHistoryMap::hasNonEmptyLocation(const Entries &Entries) const {
     const MachineInstr *MI = Entry.getInstr();
     assert(MI->isDebugValue());
     // A DBG_VALUE $noreg is an empty variable location
-    if (MI->getOperand(0).isReg() && MI->getOperand(0).getReg() == 0)
+    if (MI->isUndefDebugValue())
       continue;
 
     return true;

diff  --git a/llvm/test/DebugInfo/X86/dbg_value_list_emission.mir b/llvm/test/DebugInfo/X86/dbg_value_list_emission.mir
index e447fa82f95b3..b96582473cd0b 100644
--- a/llvm/test/DebugInfo/X86/dbg_value_list_emission.mir
+++ b/llvm/test/DebugInfo/X86/dbg_value_list_emission.mir
@@ -93,9 +93,7 @@ body:             |
     
     ; (8) Check that a single $noreg location invalidates the entire entry.
     DBG_VALUE_LIST !30, !DIExpression(DW_OP_LLVM_arg, 0, DW_OP_LLVM_arg, 1, DW_OP_plus, DW_OP_stack_value), $eax, $noreg, debug-location !15
-    ; CHECK:      DW_TAG_variable
-    ; CHECK-NEXT:   DW_AT_name ("localh")
-    ; CHECK-NOT:   DW_AT_location
+    ; CHECK-NOT:   DW_AT_name ("localh")
 
     RET64 debug-location !15
 ...