[PATCH] D140111: [lld][wasm] Split __wasm_apply_data_relocs when it exceeds the function size limit

Illia Malachyn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 20 03:25:26 PST 2022


k1nder10 added a comment.

In D140111#4004579 <https://reviews.llvm.org/D140111#4004579>, @sbc100 wrote:

> I feel like a better approach might be to generate N different functions during the generation phase rather than trying to split the function after generation?
>
> Also, I think we (also) want to investigate using a data driven approach for the relocations that don't involve symbol-specific globals.  See the discussion on that here: https://github.com/emscripten-core/emscripten/issues/12682#issuecomment-1297755521

Do we know the number of relocations (the size of __wasm_apply_data_relocs) during the generation phase?

Speaking of the discussion you provided, I also think it is a good idea. However, I don't have much time to work on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140111/new/

https://reviews.llvm.org/D140111



More information about the llvm-commits mailing list