[PATCH] D137495: [LoongArch] Add GHC Calling Convention

[wanglei via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:471
+  
+  if (isPositionIndependent()) {
+    if (IsLocal)
----------------
I think there is no need to judge here. The following modifications(switch codemodel) should also be unnecessary. This modification will change the semantics of `dso_preemptable`. https://llvm.org/docs/LangRef.html#runtime-preemption-specifiers


================
Comment at: llvm/test/CodeGen/LoongArch/ghc-cc.ll:6-25
+ at base  = external global i64 ; assigned to register: s0
+ at sp    = external global i64 ; assigned to register: s1
+ at hp    = external global i64 ; assigned to register: s2
+ at r1    = external global i64 ; assigned to register: s3
+ at r2    = external global i64 ; assigned to register: s4
+ at r3    = external global i64 ; assigned to register: s5
+ at r4    = external global i64 ; assigned to register: s6
----------------
`dso_local` can be used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137495/new/

https://reviews.llvm.org/D137495