[PATCH] D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Okay, you've convinced me. But just to clarify some of what I said earlier:

> You've pointed out that we shouldn't require people to turn off warnings, but this proposed change would not introduce more warnings/errors than whatever already exists

Yes, but it still makes turning on `-fatal_warnings` harder. And I would like to be able to turn it on for most of our builds. (We are already looking at downgrading certain warnings internally to achieve this, but I would like to minimize the number of local patches.)

> Furthermore, this means that once a build sets -ignore_linker_option=*, new missing frameworks/libraries from bad LC_LINKER_OPTIONs will be ignored.

I was thinking that we would still emit a non-warning message when we encounter missing frameworks that aren't explicitly ignored. But you're right, this is a deviation from how the existing `-ignore_linker_option` flag works for explicit ignores.

Anyway I realize that making them warnings isn't so bad because folks can use `-ignore_linker_option` to make the build warning-free. Turning on `-fatal_warnings` usually requires some build cleanup work anyway, so requiring people to figure out which libraries to ignore seems par for the course.

> Eh, in doubt I'd do what int3 recommends 😅

Please push back if things don't make sense 😅 I'm not always thinking straight...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140225/new/

https://reviews.llvm.org/D140225