[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
-      OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
-  LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
 };
----------------
TIFitis wrote:
> jdoerfert wrote:
> > TIFitis wrote:
> > > I am not sure if this change is safe. It can be avoided by making `OpenMPOffloadMappingFlags` an enum class.
> > Why do you need to change this enum at all?
> Otherwise you'd have two declarations of LLVM_MARK_AS_BITMASK_ENUM in the same namespace which is an error ofc. 
> 
> This is because they are both enums which spill the declarations to the enclosing namespace, I.e. llvm::omp
But we are using that type in binary operations w/o cast. Does this change then not break existing code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140292/new/

https://reviews.llvm.org/D140292