[PATCH] D140087: [X86] Replace (31/63 -/^ X) with (NOT X) and ignore (32/64 ^ X) when computing shift count

Mon Dec 19 18:42:08 PST 2022

goldstein.w.n added a comment.

In D140087#4006734 <https://reviews.llvm.org/D140087#4006734>, @pengfei wrote:

> In D140087#4005300 <https://reviews.llvm.org/D140087#4005300>, @goldstein.w.n wrote:
>
>> In D140087#4005193 <https://reviews.llvm.org/D140087#4005193>, @goldstein.w.n wrote:
>>
>>> In D140087#3997239 <https://reviews.llvm.org/D140087#3997239>, @pengfei wrote:
>>>
>>>> Pre-commit the test case and rebase to show the diff.
>>>
>>> What do you mean? Add a commit of not-shift.ll
>>> w.o the peephole added?
>>
>> Assume this is what you mean so made the revision two commits.
>> Think I must have messed something up though. Can you let me
>> know if this is what you mean and if not what I should do?
>>
>> Accidentally made two new revisions in the process (D140314 <https://reviews.llvm.org/D140314>/D140316 <https://reviews.llvm.org/D140316>).
>> I didn't see a way to delete them so I changed their visibility to no-one.
>> Sorry for the spam.
>
> I mean commit the test case to llvm trunk directly if you have the permission. Otherwise, you can put the test in a separate review and update this one. Tips, you can update this one with your new local commit iff you preserve the message `Differential Revision: https://reviews.llvm.org/D140087`

I see. I don't have commit access. Here is the revision with just the test:
https://reviews.llvm.org/D140362

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140087/new/

https://reviews.llvm.org/D140087