[PATCH] D139752: cmake: Enable 64bit off_t on 32bit glibc systems

[Alex Reinking via Phabricator via llvm-commits]

alexreinking added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:342
+  if (CMAKE_SIZEOF_VOID_P EQUAL 4)
+    add_definitions( -D_FILE_OFFSET_BITS=64 )
+    list(APPEND CMAKE_REQUIRED_DEFINITIONS "-D_FILE_OFFSET_BITS=64")
----------------
I believe the problem @srj encountered is caused by this line. The `add_definitions` command is bug-prone and was superseded by `add_compile_definitions` (correctly used a few lines up) in CMake 3.12.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139752/new/

https://reviews.llvm.org/D139752