[PATCH] D64829: [Xtensa 3/10] Add initial version of the Xtensa backend.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp:36
+  std::string Ret = "e-m:e-p:32:32-i8:8:32-i16:16:32-i64:64-n32";
+
+  return Ret;
----------------
delete blank line. Just return the string.


================
Comment at: llvm/lib/Target/Xtensa/XtensaTargetMachine.h:25
+
+extern Target TheXtensaTarget;
+
----------------
Other targets use a static local variable in `llvm::get*Target` but this seems fine.


================
Comment at: llvm/lib/Target/Xtensa/XtensaTargetMachine.h:28
+class XtensaTargetMachine : public LLVMTargetMachine {
+  std::unique_ptr<TargetLoweringObjectFile> TLOF;
+
----------------
include llvm/Target/TargetLoweringObjectFile.h for this


================
Comment at: llvm/lib/Target/Xtensa/XtensaTargetMachine.h:43
+
+  // Override LLVMTargetMachine
+  TargetPassConfig *createPassConfig(PassManagerBase &PM) override;
----------------
delete the comment. `override` self explains.


================
Comment at: llvm/lib/Target/Xtensa/XtensaTargetMachine.h:51
+
+#endif /* LLVM_LIB_TARGET_XTENSA_XTENSATARGETMACHINE_H */
----------------
I think all patches use `/*` footer for header guards, which should all be fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64829/new/

https://reviews.llvm.org/D64829