[llvm] 3a5426f - Revert "LTO: always parse modules in opaque pointer mode."

[Roman Lebedev via llvm-commits]

Reminder to please always mention the reason for the revert/recommit
in the commit message.

On Tue, Dec 20, 2022 at 3:02 AM Steven Wu via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Steven Wu
> Date: 2022-12-19T16:02:43-08:00
> New Revision: 3a5426f5724350bfbd970fe85ef0d0e45b50b2ee
>
> URL: https://github.com/llvm/llvm-project/commit/3a5426f5724350bfbd970fe85ef0d0e45b50b2ee
> DIFF: https://github.com/llvm/llvm-project/commit/3a5426f5724350bfbd970fe85ef0d0e45b50b2ee.diff
>
> LOG: Revert "LTO: always parse modules in opaque pointer mode."
>
> This reverts commit 8ba9a5218782fa4f94b5c516d513a4259992c254.
>
> Added:
>
>
> Modified:
>     llvm/tools/lto/lto.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/tools/lto/lto.cpp b/llvm/tools/lto/lto.cpp
> index a2d051257ea4c..f50b6ac5ae3dc 100644
> --- a/llvm/tools/lto/lto.cpp
> +++ b/llvm/tools/lto/lto.cpp
> @@ -106,7 +106,6 @@ static void lto_initialize() {
>
>      static LLVMContext Context;
>      LTOContext = &Context;
> -    LTOContext->setOpaquePointers(true);
>      LTOContext->setDiagnosticHandler(
>          std::make_unique<LTOToolDiagnosticHandler>(), true);
>      initialized = true;
> @@ -134,10 +133,7 @@ struct LibLTOCodeGenerator : LTOCodeGenerator {
>    // Module must be destructed before its context gets destructed.
>    ~LibLTOCodeGenerator() { resetMergedModule(); }
>
> -  void init() {
> -    OwnedContext->setOpaquePointers(true);
> -    setDiagnosticHandler(handleLibLTODiagnostic, nullptr);
> -  }
> +  void init() { setDiagnosticHandler(handleLibLTODiagnostic, nullptr); }
>
>    std::unique_ptr<MemoryBuffer> NativeObjectFile;
>    std::unique_ptr<LLVMContext> OwnedContext;
> @@ -275,7 +271,6 @@ lto_module_t lto_module_create_in_local_context(const void *mem, size_t length,
>
>    // Create a local context. Ownership will be transferred to LTOModule.
>    std::unique_ptr<LLVMContext> Context = std::make_unique<LLVMContext>();
> -  Context->setOpaquePointers(true);
>    Context->setDiagnosticHandler(std::make_unique<LTOToolDiagnosticHandler>(),
>                                  true);
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits