[PATCH] D64833: [Xtensa 7/10] Add Xtensa instruction printer.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.h:52
+
+#endif /* LLVM_LIB_TARGET_XTENSA_MCTARGETDESC_XTENSAINSTPRINTER_H */
----------------



================
Comment at: llvm/test/MC/Xtensa/elf-header.s:5
+# Xtensa: Format: elf32-xtensa
+# Xtensa: Arch: xtensa
+# Xtensa: AddressSize: 32bit
----------------
andreisfr wrote:
> MaskRay wrote:
> > Add `-NEXT` when applicable.
> Corrected
Not done.


================
Comment at: llvm/test/MC/Xtensa/xtensa-invalid.s:1
+# RUN: not llvm-mc  -triple xtensa < %s 2>&1 | FileCheck %s
+
----------------
llvm-mc doesn't need `<`

delete excess spaces


================
Comment at: llvm/test/MC/Xtensa/xtensa-invalid.s:9
+addi a1, a2, 300
+# CHECK:      error: expected immediate in range [-128, 127]
+
----------------
Add locations for all diagnostics ( `[[#@LINE+1]]`)


================
Comment at: llvm/test/MC/Xtensa/xtensa-invalid.s:19
+# Invalid number of operands
+addi a1, a2 # CHECK: :[[@LINE]]:1: error: too few operands for instruction
+addi a1, a2, 4, 4 # CHECK: :[[@LINE]]:17: error: invalid operand for instruction
----------------
`[[#LINE]]` is legacy syntax. Use `[[#@LINE]]`. Fix this everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64833/new/

https://reviews.llvm.org/D64833