[PATCH] D140264: [OpenMP] Improve AMDGPU Plugin

Kevin Sala Penadés via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 14:59:34 PST 2022


kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2437
+  // 	   alternative to copying them twice.
+  std::memcpy(AllArgs, *static_cast<void **>(KernelArgs),
+              sizeof(void *) * NumKernelArgs);
----------------
We should avoid copying the arguments if `NumKernelArgs` is zero.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140264/new/

https://reviews.llvm.org/D140264



More information about the llvm-commits mailing list