[PATCH] D140349: [llvm][PassSupport] don't require passes to be default constructible

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h:96
 
-  explicit AMDGPUDAGToDAGISel(TargetMachine *TM = nullptr,
-                              CodeGenOpt::Level OptLevel = CodeGenOpt::Default);
+  AMDGPUDAGToDAGISel() = delete;
+
----------------
nickdesaulniers wrote:
> efriedma wrote:
> > I don't think there's any point to explicitly deleting the default constructor (here and elsewhere); there's no implicitly-declared default constructor if there's an explicit constructor.
> @arsenm from discord:
> 
> > really the default constructor should be deleted
> 
> @arsenm WDYT? (I don't care either way; but I'd prefer agreement between you and @efriedma on how I should proceed).
I don't particularly care as long as there's no way to default construct. = delete just makes it clear that you shouldn't add it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140349/new/

https://reviews.llvm.org/D140349