[PATCH] D140324: [SDAG] neg x with only low bit demanded is x

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 14:36:50 PST 2022


reames added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:2635
+    // neg x with only low bit demanded is simply x.
+    // add 0, x with only low bit demanded is simply x
+    if (DemandedBits.isOne() &&
----------------
craig.topper wrote:
> ISD::MUL has a fallthrough into this block. I don't think this is correct for it.
Good catch, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140324/new/

https://reviews.llvm.org/D140324



More information about the llvm-commits mailing list