[PATCH] D140323: [llvm][X86ISelDAGToDAG] support -{start|stop}-{before|after}=x86-isel

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:180
 
-    StringRef getPassName() const override {
-      return "X86 DAG->DAG Instruction Selection";
-    }
+    StringRef getPassName() const override { return PASS_NAME; }
 
----------------
barannikov88 wrote:
> nickdesaulniers wrote:
> > barannikov88 wrote:
> > > Q: Is it necessary to override getPassName if the pass is registered? I thought the default implementation would extract the pass name from the registration info.
> > > 
> > A: No, but you can make it "more infomative":
> > https://github.com/llvm/llvm-project/blob/30199d11d27460e8c96a81c493526c32dbea428d/llvm/include/llvm/Pass.h#L104-L106
> Makes sense, thank you.
oh, if I remove it, I get the same result from `llc -print-before-all`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140323/new/

https://reviews.llvm.org/D140323