[PATCH] D140323: [llvm][X86ISelDAGToDAG] support -{start|stop}-{before|after}=x86-isel

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 14:25:11 PST 2022


barannikov88 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:180
 
-    StringRef getPassName() const override {
-      return "X86 DAG->DAG Instruction Selection";
-    }
+    StringRef getPassName() const override { return PASS_NAME; }
 
----------------
Q: Is it necessary to override getPassName if the pass is registered? I thought the default implementation would extract the pass name from the registration info.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140323/new/

https://reviews.llvm.org/D140323



More information about the llvm-commits mailing list