[PATCH] D140349: [llvm][PassSupport] don't require passes to be default constructible

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 14:18:27 PST 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/include/llvm/PassSupport.h:91
+Pass *callDefaultCtor() {
+  return nullptr;
+}
----------------
arsenm wrote:
> Should just be llvm_unreachable? Is this checked anywhere?
Looks like that would be called if you run the pass with opt and LPM: `opt -<passname>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140349/new/

https://reviews.llvm.org/D140349



More information about the llvm-commits mailing list