[PATCH] D133949: Make sure the right parameter extension attributes are added in various instrumentation passes.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I don't really know anything about the specific OMP function definitions; I'll assume you have it right.  (If someone more familiar could check, that would be welcome.)



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:344
+  // Add AS to FnAS while taking special care with integer extensions.
+  auto addAttrSet = [&](AttributeSet &FnAS, const AttributeSet &AS,
+                        bool Param = true) -> void {
----------------
Can we mess with the way this works so that the "attributes" from OMPKinds.def aren't directly LLVM IR attributes?  I think the current version has the right semantics, but using zext/sext as "placeholder" attributes is really confusing.  (Maybe instead of writing AttributeSet constructors in OMPKinds.def, make the names from OMP_ATTRS_SET into an enum, and put the actual code to translate from those enums to LLVM IR attributes here.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133949/new/

https://reviews.llvm.org/D133949