[PATCH] D139623: [llvm][cmake] Fix add_subdirectory build in multi-config

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 11:16:35 PST 2022


sebastian-ne added a comment.

> I still get the ${CONFIGURATION} directory even with this patch

This is caused by `set( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${LLVM_TOOLS_BINARY_DIR} )` in `llvm/CMakeLists.txt:L963`.
If I understand it correctly, `set_output_directory()` sets the individual output directories for targets to sensible directories and the generic CMAKE_RUNTIME_OUTPUT_DIRECTORY isn’t used.

I see this patch as a band-aid. Long-term, we want to get rid of `CMAKE_CFG_INTDIR` and use generator expressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139623/new/

https://reviews.llvm.org/D139623



More information about the llvm-commits mailing list