[PATCH] D140326: DAG: Use getNegatedExpression in combineMinNumMaxNum

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 11:03:26 PST 2022


arsenm created this revision.
arsenm added reviewers: bogner, spatel, bkramer, RKSimon, greened, foad.
Herald added subscribers: ecnelises, hiraditya.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Computing the negated RHS expression just to see if it compares equal
and throw it away feels dirty.


https://reviews.llvm.org/D140326

Files:
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/ARM/unsafe-fneg-select-minnum-maxnum-combine.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140326.484017.patch
Type: text/x-patch
Size: 8812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221219/69ae33ea/attachment.bin>


More information about the llvm-commits mailing list