[PATCH] D139092: [RFC][LLD][ELF] Cortex-M Security Extensions (CMSE) Support

Amilendra Kodithuwakku via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 11:01:33 PST 2022


amilendra marked 5 inline comments as done.
amilendra added inline comments.


================
Comment at: lld/ELF/Driver.cpp:346
 
-    if (!config->in_implib.empty())
       error("--in-implib is only supported on ARM targets");
----------------
MaskRay wrote:
> This piece of code doesn't exist in upstream. Please ensure the patch is against the upstream. If you have multiple commits locally, fold them.
> This piece of code doesn't exist in upstream. Please ensure the patch is against the upstream. If you have multiple commits locally, fold them.

I think it should have been fixed now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092



More information about the llvm-commits mailing list