[PATCH] D140227: [dsymutil] Verify the keep chain when asserts are enabled

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:877
+
+    for (DWARFDie Child : reverse(Current.children())) {
+      Worklist.push_back(Child);
----------------
JDevlieghere wrote:
> avl wrote:
> > it looks not neccessary to reverse here.
> You're right, but it also doesn't hurt and makes sure we visit children in order (and report them that way) which I think makes the output more like the input if there are multiple broken links for one parent.
Ok then.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:886
+
+  if (!BrokenLinks.empty()) {
+    for (BrokenLink Link : BrokenLinks) {
----------------
JDevlieghere wrote:
> avl wrote:
> > this check looks redundant.
> It guards the `report_fatal_error` below.
Oh, right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140227/new/

https://reviews.llvm.org/D140227