[PATCH] D140168: Do not mark non-phi loop var def as loop-carried dep

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added inline comments.


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:2283
   if (!DefS || !DefD || !DefS->isPHI() || !DefD->isPHI())
-    return true;
+    return false;
 
----------------
If we don't know the definition for BaseOpsS or BaseOpsD, then we have to be conservative and assume a loop carried dependence.  

Perhaps we need to handle two cases, one when BaseOpsS is the same as BaseOpsD, and the other is when they aren't the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140168/new/

https://reviews.llvm.org/D140168