[PATCH] D139902: IR: Add nofpclass parameter attribute

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 19 09:57:12 PST 2022


nikic added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1409
+    indicated by ``nofpclass``, the value read is a :ref:`poison value
+    <poisonvalues>`.
+
----------------
The wording here is unusual -- we'd normally just say that the argument/return is poison. Why the focus on the using operation here?


================
Comment at: llvm/docs/LangRef.rst:1424
+   <denormal_fp_math>` indicating zero treatment of input denormals,
+   it cannot be assumed the value is 0; it may still be a denormal.
+
----------------
I don't really get what this whole paragraph is trying to say.

Please at least write out the 0xf0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139902/new/

https://reviews.llvm.org/D139902



More information about the llvm-commits mailing list